Mirrors/home-manager
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

network-manager-applet: remove --sm-disable flag

Browse source 
The `--sm-disable` flag is deprecated. It doesn't show in the man
pages, any documentation, and others have seemed to notice as well:

> The `--sm-disable` flag isn't used anymore due to the applet no longer being session-managed.

From: <https://askubuntu.com/a/525273>

Which cites: <https://mail.gnome.org/archives/networkmanager-list/2011-May/msg00141.html>

PR #4296
This commit is contained in:
cvoges12 2023-08-01 18:44:46 -05:00 committed by Robert Helgesson
parent a146ab6a61
commit 484a1c9442
No known key found for this signature in database
GPG key ID: 36BDAA14C2797E89
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/lib/maintainers.nix
View file

@ -37,6 +37,12 @@
github = "CarlosLoboxyz"; github = "CarlosLoboxyz";
githubId = 86011416; githubId = 86011416;
}; };
cvoges12 = {
name = "Clayton Voges";
email = "38054771+cvoges12@users.noreply.github.com";
github = "cvoges12";
githubId = 38054771;
};
d-dervishi = { d-dervishi = {
email = "david.dervishi@epfl.ch"; email = "david.dervishi@epfl.ch";
github = "d-dervishi"; github = "d-dervishi";

8
modules/services/network-manager-applet.nix
View file

@ -7,7 +7,7 @@ let
cfg = config.services.network-manager-applet; cfg = config.services.network-manager-applet;
in { in {
meta.maintainers = [ maintainers.rycee ]; meta.maintainers = [ maintainers.rycee hm.maintainers.cvoges12 ];
options = { options = {
services.network-manager-applet = { services.network-manager-applet = {
@ -32,10 +32,8 @@ in {
Install = { WantedBy = [ "graphical-session.target" ]; }; Install = { WantedBy = [ "graphical-session.target" ]; };
Service = { Service = {
ExecStart = toString ExecStart = toString ([ "${pkgs.networkmanagerapplet}/bin/nm-applet" ]
([ "${pkgs.networkmanagerapplet}/bin/nm-applet" "--sm-disable" ] ++ optional config.xsession.preferStatusNotifierItems "--indicator");
++ optional config.xsession.preferStatusNotifierItems
"--indicator");
}; };
}; };
}; };