fix error when deleting empty directories

With --ignore-fail-on-non-empty, non-emptiness is the only failure that
gets ignored by rmdir.
In the case that rmdir reaches $HOME and considers deleting it, it will
detect insufficient permissions and subsequently exit with an error,
even if $HOME is not empty.

Prevent this by calling rmdir with a relative path that excludes $HOME.

modules/home-environment.nix

@@ -315,16 +315,17 @@ in
             else
               echo "Checking $targetPath  gone (deleting)"
               $DRY_RUN_CMD rm $VERBOSE_ARG "$targetPath"
-              targetDir="$(dirname "$targetPath")"
 
-              # Recursively remove the containing directory. We only
+              # Recursively delete empty parent directories.
-              # do this if the containing folder is not $HOME since
+              targetDir="$(dirname "$relativePath")"
-              # running rmdir on $HOME will result in a harmless but
+              if [[ "$targetDir" != "." ]] ; then
-              # unpleasant error message.
+                pushd "$HOME" > /dev/null
-              if [[ "$targetDir" != "$HOME" ]] ; then
+                # Call rmdir with a relative path excluding $HOME. Otherwise, it
+                # might try to delete $HOME and exit with a permission error.
                 $DRY_RUN_CMD rmdir $VERBOSE_ARG \
                     -p --ignore-fail-on-non-empty \
                     "$targetDir"
+                popd > /dev/null
               fi
             fi
           done