From fceef469c2ec99232d847f1d9d6b32665d915bbb Mon Sep 17 00:00:00 2001 From: jD91mZM2 Date: Wed, 12 Aug 2020 22:51:20 +0200 Subject: [PATCH] xdg-user-dirs: fix erroneous dirs file Before this change, ```rust fn main() { println!("{:?}", glib::get_user_special_dir(glib::UserDirectory::Documents)); } ``` would return `None` even though `~/Documents` is available and `xdg.userDirs.enable = true`. Checking the differences between `xdg-user-dirs-update` shows that the latter has quotes around each thing. PR #1440 --- modules/misc/xdg-user-dirs.nix | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/modules/misc/xdg-user-dirs.nix b/modules/misc/xdg-user-dirs.nix index 854eaf83..a1db6b11 100644 --- a/modules/misc/xdg-user-dirs.nix +++ b/modules/misc/xdg-user-dirs.nix @@ -89,16 +89,21 @@ in { }; config = mkIf cfg.enable { - xdg.configFile."user-dirs.dirs".text = generators.toKeyValue { } ({ - XDG_DESKTOP_DIR = cfg.desktop; - XDG_DOCUMENTS_DIR = cfg.documents; - XDG_DOWNLOAD_DIR = cfg.download; - XDG_MUSIC_DIR = cfg.music; - XDG_PICTURES_DIR = cfg.pictures; - XDG_PUBLICSHARE_DIR = cfg.publicShare; - XDG_TEMPLATES_DIR = cfg.templates; - XDG_VIDEOS_DIR = cfg.videos; - } // cfg.extraConfig); + xdg.configFile."user-dirs.dirs".text = let + options = { + XDG_DESKTOP_DIR = cfg.desktop; + XDG_DOCUMENTS_DIR = cfg.documents; + XDG_DOWNLOAD_DIR = cfg.download; + XDG_MUSIC_DIR = cfg.music; + XDG_PICTURES_DIR = cfg.pictures; + XDG_PUBLICSHARE_DIR = cfg.publicShare; + XDG_TEMPLATES_DIR = cfg.templates; + XDG_VIDEOS_DIR = cfg.videos; + } // cfg.extraConfig; + + # For some reason, these need to be wrapped with quotes to be valid. + wrapped = mapAttrs (_: value: ''"${value}"'') options; + in generators.toKeyValue { } wrapped; xdg.configFile."user-dirs.conf".text = "enabled=False"; };